Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build with versions of OpenSSL < 0.9.8 #2305

Closed
wants to merge 1 commit into from
Closed

fix build with versions of OpenSSL < 0.9.8 #2305

wants to merge 1 commit into from

Conversation

dougmencken
Copy link
Contributor

support for SHA-2 was introduced in OpenSSL 0.9.8

@bagder
Copy link
Member

bagder commented Feb 12, 2018

The CURL_SHA256_OPENSSL symbol is already used so this conflicts and causes the CI failures. Maybe USE_OPENSSL_SHA256 ?

@dougmencken
fix build with versions of OpenSSL < 0.9.8
d256f5d 
support for SHA-2 was introduced in OpenSSL 0.9.8
@dougmencken
Copy link
Contributor Author

Sure

@dougmencken
Copy link
Contributor Author

dougmencken@d256f5d

And I dunno how to update this request without opening the new one

@bagder
Copy link
Member

bagder commented Feb 12, 2018

You can just commit a new commit and push that. Or amend the previous commit and "push -f" on this branch.

@bagder
Copy link
Member

bagder commented Feb 12, 2018

But I can just get the patch you have there, no worries.

@bagder bagder closed this in 50c0033 Feb 12, 2018
@bagder
Copy link
Member

bagder commented Feb 12, 2018

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
build TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dougmencken @bagder