Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in README #2300

Closed
wants to merge 1 commit into from
Closed

Fix typo in README #2300

wants to merge 1 commit into from

Conversation

brunograsselli
Copy link
Contributor

I think there is a typo in the README.

bagder
bagder requested changes Feb 9, 2018
View reviewed changes
README.md Outdated
@@ -38,7 +38,7 @@ downloads.

## Git

To download the very latest source off the Git server do this:
To download the very latest source of the Git server do this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the meaning of the sentence. The latest source of the server would imply you get a server source code downloaded. Downloading it off the server would imply you get it from the server.

Maybe use from instead of off ?

@brunograsselli
Fix typo in README
34ab1fd 
I think there is a typo in the README.
@brunograsselli
Copy link
Contributor Author

@bagder I see your point. I changed to use from instead of of.
Feel free to reject the PR in case off makes more sense than from.

@bagder bagder closed this in b9e3233 Feb 12, 2018
@bagder
Copy link
Member

bagder commented Feb 12, 2018

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brunograsselli @bagder