smb.c: Fixed 'bad suffix on number' on VC6 & 7 #2211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The function First, we should fix the second argument to not use a void pointer and instead pass in a correct type. Then, it seems the second argument is only ever |
|
How about changing the order of the math? If we divide with 10 million first, we can deduct a much smaller value that shouldn't need any suffix at all for any compiler? If my thinking is right, it shouldn't change the net result. |
|
@bagder Anything that suits you. I just want to make it compile 😉 |
bagder
added a commit
that referenced
this pull request
Jan 15, 2018
1. don't use "ULL" suffix since unsupported in older MSVC 2. use curl_off_t instead of custom long long ifdefs 3. make get_posix_time() not do unaligned data access Fixes #2211 Reported-by: Chester Liu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.