Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL: return error on malformed URLs with junk after IPv6 bracket #2072

Closed
wants to merge 1 commit into from
Closed

URL: return error on malformed URLs with junk after IPv6 bracket #2072

wants to merge 1 commit into from

Conversation

mkauf
Copy link
Contributor

@mkauf mkauf commented Nov 12, 2017

Follow-up to aadb7c7. Verified by new test 1263.

jay
jay reviewed Nov 12, 2017
View reviewed changes
lib/url.c
}
}
else
portptr = NULL; /* no port number available */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will push a fixed version.

@mkauf mkauf closed this in ae7369b Nov 14, 2017
@mkauf mkauf deleted the url_ipv6_bracket branch November 14, 2017 17:23
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jay jay jay left review comments

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkauf @bagder @jay