Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not jump over semicolons when filename contains a path #1964

Closed
wants to merge 1 commit into from
Closed

Do not jump over semicolons when filename contains a path #1964

wants to merge 1 commit into from

Conversation

cuklev
Copy link
Contributor

@cuklev cuklev commented Oct 7, 2017

Content-Disposition: attachment; filename=correct.jpg; somethingelse=/wrong.jpg
curl -O -J saves to wrong.jpg when it should probably save to correct.jpg.

@cuklev cuklev changed the title Do not jump over seimicolons when filename contains a path Do not jump over semicolons when filename contains a path Oct 7, 2017
bagder
bagder approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also updated test 1422 to verify this and will amend your commit with it when I merge!

@bagder
Copy link
Member

bagder commented Oct 9, 2017

Thanks!

@bagder bagder closed this in c95c92d Oct 9, 2017
@cuklev cuklev deleted the content-disposition-filename-parse branch December 5, 2017 22:07
@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
cmdline tool HTTP
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cuklev @bagder