Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: enable PKCS12 support for !BoringSSL #1948

Closed
wants to merge 1 commit into from
Closed

openssl: enable PKCS12 support for !BoringSSL #1948

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Oct 5, 2017

Enable PKCS12 for all non-boringssl builds without relying on configure
or cmake checks.

Bug: https://curl.haxx.se/mail/lib-2017-10/0007.html
Reported-by: Christian Schmitz

@bagder
openssl: enable PKCS12 support for !BoringSSL
f37d1c0 
Enable PKCS12 for all non-boringssl builds without relying on configure
or cmake checks.

Bug: https://curl.haxx.se/mail/lib-2017-10/0007.html
Reported-by: Christian Schmitz
@bagder bagder closed this in 62a721e Oct 9, 2017
@bagder bagder deleted the bagder/openssl-pkcs12 branch October 9, 2017 09:30
@bagder
Copy link
Member Author

bagder commented Oct 9, 2017

No feedback on this take but I merged anyway as I believe this is the right way forward.

@gvanem
Copy link
Contributor

gvanem commented Nov 22, 2017

What about the case with multiple SSL backends; both -DUSE_OPENSSL (meaning true OpenSSL) and
-DOPENSSL_IS_BORINGSSL?

Is it possible to detect that at compile time? No #error don't do that! for that in the code now AFAICS..

@jay
Copy link
Member

jay commented Nov 22, 2017 •
edited

What about the case with multiple SSL backends; both -DUSE_OPENSSL (meaning true OpenSSL) and
-DOPENSSL_IS_BORINGSSL?

I don't think it's possible to use both of those at the same time. edit: I mean you either use openssl or boringssl. USE_OPENSSL should be defined in either case

@gvanem
Copy link
Contributor

gvanem commented Nov 22, 2017 •
edited

I know; I got the error for a missing <pkcs12.h> in BoringSSL. Hence the question.

@jay
Copy link
Member

jay commented Nov 22, 2017

I'm lost. If you are building with BoringSSL then the pkcs stuff should not be included. In other words -DUSE_OPENSSL -DOPENSSL_IS_BORINGSSL then no pkcs

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
build TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bagder @gvanem @jay