Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: test for and enable picky compiler options #1799

Closed
wants to merge 2 commits into from
Closed

cmake: test for and enable picky compiler options #1799

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 17, 2017

No description provided.

@bagder bagder added the cmake label Aug 17, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 73.228% when pulling 0870d6b on bagder/cmake-picky-options into 6b9bc5a on master.

@MarcelRaad
Copy link
Member

I like the default being on, but that's probably only a good idea for GCC-compatible compilers - -Wall for Visual Studio is the same as -Weverything for clang.

@bagder
Copy link
Member Author

bagder commented Aug 17, 2017

that explains the massive breakage on Windows... =)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 73.224% when pulling 6e12ee9 on bagder/cmake-picky-options into 6b9bc5a on master.

@bagder bagder closed this in b939542 Aug 20, 2017
@bagder bagder deleted the bagder/cmake-picky-options branch August 20, 2017 21:33
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bagder @coveralls @MarcelRaad