New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system.h: remove all CURL_SIZEOF_* defines #1767
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/system-h-remove-sizes
branch
from
August 12, 2017 13:57
8be8a01
to
4dfab82
Compare
My opinion is CURL_SIZEOF_ for curl types is appropriate. Is there some reason not to have them, and couldn't this be addressed by just removing CURL_SIZEOF_LONG? |
I want to remove the SIZEOF defines from there because:
|
bagder
force-pushed
the
bagder/system-h-remove-sizes
branch
from
August 15, 2017 16:54
4dfab82
to
c486957
Compare
Rebased and fixed merge conflicts |
bagder
removed
the
feature-window
A merge of this requires an open feature window
label
Aug 15, 2017
... as they're not used externally and internally we check for the sizes already in configure etc.
bagder
force-pushed
the
bagder/system-h-remove-sizes
branch
from
August 16, 2017 05:59
a5c139b
to
6ccbdd1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as they're not used externally and internally we check for the sizes
already in configure etc.