Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Allow user to override CMAKE_DEBUG_POSTFIX #1763

Closed
wants to merge 1 commit into from
Closed

cmake: Allow user to override CMAKE_DEBUG_POSTFIX #1763

wants to merge 1 commit into from

Conversation

webmaster128
Copy link
Contributor

In #1649 the cache variable CMAKE_DEBUG_POSTFIX was set to "-d" by FORCE, giving the user no chance to override it to the desired value. This change keeps "-d" as default but allows users to change the value.

Current master

$ mkdir build && cd build
$ cmake -DCMAKE_BUILD_TYPE=Debug ..
$ DESTDIR=installation make install

-- Installing: installation/usr/local/lib/libcurl-d.so

$ mkdir build && cd build
$ cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_DEBUG_POSTFIX=_bar ..
$ DESTDIR=installation make install

-- Installing: installation/usr/local/lib/libcurl-d.so

This PR

$ mkdir build && cd build
$ cmake -DCMAKE_BUILD_TYPE=Debug ..
$ DESTDIR=installation make install

-- Installing: installation/usr/local/lib/libcurl-d.so

$ mkdir build && cd build
$ cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_DEBUG_POSTFIX=_bar ..
$ DESTDIR=installation make install

-- Installing: installation/usr/local/lib/libcurl_bar.so

cc @paulharris

@mention-bot
Copy link

@webmaster128, thanks for your PR! By analyzing the history of the files in this pull request, we identified @snikulov, @billhoffman and @Sukender to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 75.099% when pulling 0b2931a on webmaster128:custom_suffix into 77cd4e7 on curl:master.

@bagder bagder added the cmake label Aug 11, 2017
bagder
bagder approved these changes Aug 11, 2017
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems totally reasonable to me!

@bagder bagder closed this in 7f9bf5c Aug 12, 2017
@bagder
Copy link
Member

bagder commented Aug 12, 2017

Thanks!

@webmaster128 webmaster128 mentioned this pull request Sep 4, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@webmaster128 @mention-bot @coveralls @bagder