Skip to content

libssh: add NULL check for Curl_meta_get() #17359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented May 15, 2025

It really cannot return NULL in a working condition, but ...

Pointed out by Coverity.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
It really cannot return NULL in a working condition, but ...

Pointed out by Coverity.
@bagder bagder force-pushed the bagder/libssh-meta-get branch from 7675b9c to ef83c48 Compare May 15, 2025 20:45
@testclutch
Copy link

Analysis of PR #17359 at 7675b9c9:

Test 1173 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 36 different CI jobs (the link just goes to one of them).

Generated by Testclutch

@bagder bagder marked this pull request as ready for review May 15, 2025 20:58
@bagder bagder closed this in 96726af May 15, 2025
@bagder bagder deleted the bagder/libssh-meta-get branch May 15, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants