spacecheck.pl: verify tests/data/test* for non-ASCII chars
#17329
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude test data files (4 of them) based on existing feature tags: `codeset-utf8` and `Unicode`. Add a new feature 'codeset-non-ascii' to mark remaining exceptions (9 files). Follow-up to 838dc53 curl#17247
vszakats
changed the title
tests/data/test* files for non-ASCII charstests/data/test* for non-ASCII chars
|
This new feature should be documented in tests/FILEFORMAT.md preferably with a description since it's not obvious what it does by the name. |
|
When you make this a feature, you make sure that all curl builds that are built without this feature (all of them) will skip these tests. I propose you don't abuse the feature tag for this tagging of test files. Perhaps use |
|
Ah, indeed, I forgot about the side-effect. Settled with making it a |
This comment was marked as outdated.
This comment was marked as outdated.
bagder
approved these changes
May 13, 2025
|
Instead of skipping the UTF check for these files, we can fix them to use hex encoding instead of UTF-8. I made a test shot of this in #17331 |
vszakats
added a commit
that referenced
this pull request
May 13, 2025
- replace ß (scharfes S) with links.
- replace § (section sign) with links.
- replace 🙏 emoji with `:pray:`.
Supported by GitHub, Forgejo/Gitea and most likely GitLab.
- docs/libcurl/curl_mprintf.md: replace Unicode ± with `{+|-}`.
- docs/CIPHERS.md: URL encode Unicode in URLs.
- lib1560: use hex encoding in `räksmörgås.se`.
- unit1307: use hex encoding in `Lindmätarv`.
- drop LATIN SMALL LETTER A WITH ACUTE exception.
No longer appears in tests.
This leaves the single character exception: `ö`
And file exceptions holding contributor names.
Follow-up to 9243ed5 #17329
Follow-up to 838dc53 #17247
Closes #17335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude test data files (4 of them) based on existing feature tags:
codeset-utf8andUnicode.Add the new keyword
non-asciito mark remaining exceptions (9 files).Follow-up to 838dc53 #17247