New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: add initial gssapi test using stub implementation #1687
Conversation
Hey, this aims to replace #761, simpler and not requiring the whole kerberos setup. |
7383b5a
to
99036cd
Compare
Typo in commit message ("impelentation"), otherwise looks very good to me. The copyright dates are set to 2015, no idea if that matters. |
Thanks @MarcelRaad! I'll fix those along with some other minor changes I have in mind. |
Instinctively, I would just change build type "normal" to include |
Yea, I think I'll do that (remove the normal linux build) later on. |
Ok, I gave up the usage of 'swsbounce' in favor of a special negotiate handler on the server which increments partno by one for each request with negotiate authorization header on the same test. |
d5ffedf
to
adec429
Compare
btw, a slightly different approach, which would work with debug build, could be to add a configuration option to build the stub gss library as a static library and linked to it instead to real gss library so there no need for ld_preload (nor for real gss package). |
7b46182
to
df51ece
Compare
Update: I've rebased on master, and moved the memory-leak fix to another PR. |
That was silly as now the corresponding test (2057) fails. I'll re-borrow that commit. |
You don't need to, I'm just about to merge it. |
I merged the two PRs fixing the Travis failures now, so you just need to rebase on current master. |
.travis.yml
Outdated
@@ -26,6 +27,9 @@ matrix: | |||
dist: trusty | |||
env: T=normal | |||
- os: linux | |||
compiler: gcc | |||
env: T=gssapi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the recent changes to this file, maybe just C=--with-gssapi could be added to the linux/normal build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll try that, thanks!
I also want to try out the other approach suggested few comments above as a separate PR, so we can look at both approaches.
07d0572
to
02c86ac
Compare
02c86ac
to
a57ee53
Compare
(I gave up on the other approach as it has got complicated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I plan to try it out tomorrow.
Sorry for the long delay! With MSYS2 MSYS (x86_64-pc-msys) as well as Cygwin64 (x86_64-unknown-cygwin), configured with
and then:
Is this expected? Will try on openSUSE Leap 42.2 SP2 tonight. |
Works perfectly on the openSUSE Leap 42.2 SP2 from Windows 10. |
Sorry for the delay and thanks for looking at it and for trying it out. I was able to reproduce the failure on cygwin and I'm looking into it. |
I was able to get around the warning by adding -no-undefined to libstubgss_la_LDFLAGS, however the tests still fail since LD_PRELOAD isn't supported. Other tests using LD_PRELOAD fail as well on cygwin. |
6f77c27
to
4dfaf4e
Compare
The stub implementation is pre-loaded using LD_PRELOAD and emulates common gssapi uses (only builds if curl is initially built with gssapi support). The initial tests are currently disabled for debug builds as LD_PRELOAD is not used then.
4dfaf4e
to
cb91c3f
Compare
Hey, I added an exclusion for systems not supporting LD_PRELOAD, as it is currently a requirement. |
Great! Sorry for being so unresponsive, I've had no internet access at home for the past 11 weeks. That should change tomorrow, so if all goes well, I'd like to merge this tomorrow if there are no objections. |
Thank you for working on this! |
The stub implementation is pre-loaded using LD_PRELOAD and emulates common gssapi uses (only builds if curl is initially built with gssapi support). The initial tests are currently disabled for debug builds as LD_PRELOAD is not used then. Ref: curl#1687
The stub implementation is pre-loaded using LD_PRELOAD
and emulates common gssapi uses (only builds if curl is
initially built with gssapi support).
The initial test is currently disabled for debug builds
as LD_PRELOAD is not used then.