-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtests: fix test key format for libssh2 WinCNG (and others) #16781
Conversation
Confirmed that the SSH auth failures also happen with the MSYS2 libssh2-wincng package, not just with vcpkg's https://github.com/curl/curl/actions/runs/13990239834/job/39172667787 |
This comment was marked as outdated.
This comment was marked as outdated.
ed4a000
to
f1c24b7
Compare
Ok, the solution is clear. |
The reason for the failing libssh2 WinCNG tests was that the default |
f1c24b7
to
c0978c2
Compare
c0978c2
to
f024862
Compare
All this effort, just to discover that with that fixed, the tests are flaky now If you have an insight on why this happens and how to fix it, let us know. Ref: libssh2/libssh2#804 |
SFTP/SCP tests were failing in CI with WinCNG libssh2 since we first
added such job. With
curl: (67) Authentication failure
.The reason is that the default
ssh-keygen
RSA private key formatchanged to OpenSSH (RFC4716) in 2018. libssh2 does not support this
format with some of its crypto backends.
Fix it by generating keys explicitly in PEM format as necessary via
the
-m
option. This format is universally recognized for RSA keys.2018-08-24: https://www.openssh.com/txt/release-7.8: OpenSSH format becomes default
2010-08-23: https://www.openssh.com/txt/release-5.6:
-m
option first supportedThis fixed the auth issue, just to reveal a known flakiness issue in
libssh2 + WinCNG, causing:
Ref: https://github.com/curl/curl/actions/runs/14000494428/job/39205633258?pr=16781#step:15:1796
Tracked here: libssh2/libssh2#804
Mitigated in libssh2 tests by retrying them.
Due to this, keep ignoring these test results.
Also:
CURL_TEST_SSH_KEY_FORMAT
Follow-up to 4911e7a #16735
Follow-up to 0ec72c1 #16672
Follow-up to e53523f #14859
Follow-up to e26cbe2 #13979