Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl_setup: always define WIN32_LEAN_AND_MEAN on Windows #1672

Merged
merged 1 commit into from Jul 11, 2017
Merged

curl_setup: always define WIN32_LEAN_AND_MEAN on Windows #1672

merged 1 commit into from Jul 11, 2017

Conversation

MarcelRaad
Copy link
Member

Make sure to always define WIN32_LEAN_AND_MEAN before including any
Windows headers to avoid pulling in unnecessary headers. This avoids
unnecessary macro clashes and compiler warnings.

Ref: #1562

Supersedes #1668 and part of #1667.

@MarcelRaad MarcelRaad mentioned this pull request Jul 10, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 7542153 on MarcelRaad:win32_lean_and_mean into a5834e5 on curl:master.

@jay
Copy link
Member

jay commented Jul 11, 2017

Working in VS2010 project, winbuild and also passing appveyor CI so let's see what happens

@MarcelRaad
curl_setup: always define WIN32_LEAN_AND_MEAN on Windows
beb0848 
Make sure to always define WIN32_LEAN_AND_MEAN before including any
Windows headers to avoid pulling in unnecessary headers. This avoids
unnecessary macro clashes and compiler warnings.

Ref: curl#1562
Closes curl#1672
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 75.986% when pulling beb0848 on MarcelRaad:win32_lean_and_mean into c5e87fd on curl:master.

@MarcelRaad MarcelRaad merged commit beb0848 into curl:master Jul 11, 2017
@MarcelRaad MarcelRaad deleted the win32_lean_and_mean branch July 11, 2017 11:15
@MarcelRaad
Copy link
Member Author

Thanks for testing!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarcelRaad @coveralls @jay