Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtests: fix SSH server not starting in cases, re-ignore failing vcpkg CI jobs #16636

Closed
wants to merge 8 commits into from
Closed

runtests: fix SSH server not starting in cases, re-ignore failing vcpkg CI jobs #16636

wants to merge 8 commits into from
+15 −6

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Mar 9, 2025 •
edited
Loading

Replace Cwd::abs_path() with File::Spec->rel2abs(). The former
requires the file to exist, but in some cases, it's missing.

Seen in MSVC vcpkg jobs using Chocolatey OpenSSH v8.0.0.1 ending up with
$path=/d/a/curl/curl/bld/tests/log/3/server/ssh_server.pid, which does
not exist while converting to an absolute path (the path is already
absolute, but the conversion is done unconditionally):

Use of uninitialized value in subroutine entry at D:/a/curl/curl/tests/pathhelp.pm line 128.
can't convert empty path at D:/a/curl/curl/tests/pathhelp.pm line 128.

Ref: https://github.com/curl/curl/actions/runs/13747741797/job/38444844173#step:14:1233 (master)
Ref: https://github.com/curl/curl/actions/runs/13751862952/job/38453816737#step:14:3185 (trace)

Also ignore 3 new libssh2 jobs failing due to memleak.

Partial revert of 1bd5ac9 #16570

@vszakats
runtests: verbose=1, to see why SSH server no longer starts in vcpkg …

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
66db2f7 
…jobs
@github-actions github-actions bot added the tests label Mar 9, 2025
@vszakats vszakats added SCP/SFTP Windows Windows-specific CI Continuous Integration labels Mar 9, 2025
@testclutch

This comment was marked as resolved.

Sign in to view
@vszakats vszakats force-pushed the gha-vcpkg-ssh-broken branch from c11afc4 to 0c8d877 Compare March 9, 2025 20:53
@vszakats vszakats changed the title runtests: verbose=1, to see why SSH server no longer starts in vcpkg jobs runtests: fix SSH server not starting in cases, re-ignore failing CI jobs Mar 9, 2025
@vszakats vszakats changed the title runtests: fix SSH server not starting in cases, re-ignore failing CI jobs runtests: fix SSH server not starting in cases, ignore failing CI jobs again Mar 9, 2025
@vszakats vszakats changed the title runtests: fix SSH server not starting in cases, ignore failing CI jobs again runtests: fix SSH server not starting in cases, ignore failing vcpkg CI jobs again Mar 9, 2025
@vszakats
Copy link
Member Author

vszakats commented Mar 9, 2025 •
edited
Loading

New failures:
vcpkg OpenSSL jobs:

test 0615...[SFTP put remote failure]
  
  ** MEMORY FAILURE
  Leak detected: memory still allocated: 22 bytes
  At 267fd299708, there's 22 bytes.
   allocated by D:/a/curl/curl/lib/vssh/libssh2.c:2006

 test 0616...[SFTP retrieval of empty file]
  
  ** MEMORY FAILURE
  Leak detected: memory still allocated: 22 bytes
  At 25a59317a08, there's 22 bytes.
   allocated by D:/a/curl/curl/lib/vssh/libssh2.c:2006

test 0618...[SFTP retrieval of two files]
  
  ** MEMORY FAILURE
  Leak detected: memory still allocated: 22 bytes
  At 1b708e05e78, there's 22 bytes.
   allocated by D:/a/curl/curl/lib/vssh/libssh2.c:2006

test 0620...[SFTP retrieval of missing file followed by good file]
  
  ** MEMORY FAILURE
  Leak detected: memory still allocated: 22 bytes
  At 1687d2b5e98, there's 22 bytes.
   allocated by D:/a/curl/curl/lib/vssh/libssh2.c:2006

test 0622...[SFTP put failure]
  
  ** MEMORY FAILURE
  Leak detected: memory still allocated: 22 bytes
  At 2ae5b8a7ab8, there's 22 bytes.
   allocated by D:/a/curl/curl/lib/vssh/libssh2.c:2006

https://github.com/curl/curl/actions/runs/13752652590/job/38455575042?pr=16636#step:14:3907
https://github.com/curl/curl/actions/runs/13752879003/job/38456075461

curl/lib/vssh/libssh2.c

Line 2006 in 5681628

sshc->homedir = strdup(sshp->readdir_filename);

@vszakats vszakats closed this in 61d3061 Mar 9, 2025
@vszakats vszakats changed the title runtests: fix SSH server not starting in cases, ignore failing vcpkg CI jobs again runtests: fix SSH server not starting in cases, re-ignore failing vcpkg CI jobs Mar 9, 2025
@vszakats vszakats deleted the gha-vcpkg-ssh-broken branch March 9, 2025 22:29
@vszakats vszakats mentioned this pull request Mar 9, 2025
Closed
vszakats added a commit that referenced this pull request Mar 10, 2025
@vszakats
libssh2: fix memory leak in SSH_SFTP_REALPATH state
30739b4 
Seen in MSVC libssh2 CI job:
```
test 0615...[SFTP put remote failure]
test 0616...[SFTP retrieval of empty file]
test 0618...[SFTP retrieval of two files]
test 0620...[SFTP retrieval of missing file followed by good file]
test 0622...[SFTP put failure]
test 0637...[SFTP retrieval with invalid X- range]
test 0640...[SFTP --head retrieval]
  ** MEMORY FAILURE
  Leak detected: memory still allocated: 22 bytes
  At 2ae5b8a7ab8, there's 22 bytes.
   allocated by D:/a/curl/curl/lib/vssh/libssh2.c:2006
```
https://github.com/curl/curl/actions/runs/13752652590/job/38455575042?pr=16636#step:14:3907
https://github.com/curl/curl/actions/runs/13752879003/job/38456075461
https://github.com/curl/curl/actions/runs/13753706458/job/38457888479

Bug: #16636 (comment)
Co-authored-by: Daniel Stenberg

Closes #16639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration SCP/SFTP tests Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vszakats @testclutch