Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib2302: fix crash due to stack overflow on MSVC and clang Windows #16630

Closed
wants to merge 5 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Mar 9, 2025

It fixes test 2302, 2303, 2307 with MSVC and clang on Windows.
GCC Windows builds were not affected.

Failure was caused by stack overflow due to a 1MB+ sized test struct on
stack. Replace it with dynamic allocation.

Also unignore affected tests in GHA/windows.

As seen under WINE with llvm-mingw:

$ wine64 libtests.exe lib2302 ws://127.0.0.1:59964/2302 > stdout2302 2> stderr2302
Test: lib2302
URL: ws://127.0.0.1:59964/2302
wine: Unhandled stack overflow at address 000000014007486A (thread 0024), starting debugger...
Unhandled exception: stack overflow in 64-bit code (0x000000014007486a).

Ref: #16629 (discovery)
Ref: 1bd5ac9 #16570


Sorry, something went wrong.

@vszakats vszakats added tests Windows Windows-specific CI Continuous Integration WebSocket labels Mar 9, 2025
@vszakats vszakats changed the title lib2302: fix crash due to large stack buffer on MSVC and clang Windows lib2302: fix crash due to stack overflow on MSVC and clang Windows Mar 9, 2025
@testclutch

This comment was marked as resolved.

vszakats added 2 commits March 9, 2025 03:32

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats
@vszakats vszakats force-pushed the lib2302-crash-fix branch from 218c4e9 to 2e57cd8 Compare March 9, 2025 02:32
vszakats and others added 3 commits March 9, 2025 03:41

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats
@vszakats vszakats closed this in 7e282e1 Mar 9, 2025
@vszakats vszakats deleted the lib2302-crash-fix branch March 9, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tests WebSocket Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

None yet

2 participants