Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool_operate: fail SSH transfers without server auth #16205

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 6, 2025

This now insists on using a server auth option unless --insecure is provided. As an added bonus, it now also only checks for the knownhosts file once (if found).

Ref: #16197

@testclutch
Copy link

Analysis of PR #16205 at d72ab498:

Test 445 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 14 different CI jobs (the link just goes to one of them).

Test 498 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder bagder force-pushed the bagder/stricter-ssh branch from d72ab49 to 0419849 Compare February 12, 2025 12:10
bagder added a commit that referenced this pull request Feb 17, 2025

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
This now insists on using a server auth option unless --insecure is
provided. As an added bonus, it now also only checks for the knownhosts
file once (if found).

Ref: #16197
Closes #16205
@bagder bagder force-pushed the bagder/stricter-ssh branch from 0419849 to 37369cb Compare February 17, 2025 12:27

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
This now insists on using a server auth option unless --insecure is
provided. As an added bonus, it now also only checks for the knownhosts
file once (if found).

Ref: #16197
Closes #16205
@bagder bagder force-pushed the bagder/stricter-ssh branch from 37369cb to 343a9d9 Compare February 22, 2025 12:05

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants