Skip to content

cmake/Find: add iphlpapi for c-ares, omit syslibs if dep not found #16089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 26, 2025


w/o whitespace: https://github.com/curl/curl/pull/16089/files?w=1

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats
@vszakats vszakats changed the title cmake/Find: add iphlpapi for c-ares, do not add syslibs when dep not found cmake/Find: add iphlpapi for c-ares, omit syslibs if dep not found Jan 26, 2025
@vszakats vszakats closed this in 3e552ef Jan 26, 2025
@vszakats vszakats deleted the cm-find-fixups branch January 26, 2025 00:53
vszakats added a commit to curl/curl-for-win that referenced this pull request Jan 26, 2025

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats
vszakats added a commit to curl/curl-for-win that referenced this pull request Jan 26, 2025

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats
vszakats added a commit to curl/curl-for-win that referenced this pull request Jan 26, 2025

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
- add `iphlpapi` library for c-ares.
  Ref: curl/curl-for-win@082d98b

- fix to not add system libs if the dependency was not found.
  librtmp, Rustls, wolfSSL
  Follow-up to 421e592 curl#15832
  Follow-up to 7bab201 curl#15193

Closes curl#16089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant