Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: enable typecheck-gcc warnings #1595

Closed
wants to merge 1 commit into from

Conversation

MarcelRaad
Copy link
Member

  • switch debug and release configurations so that we get an optimized
    build with GCC 4.3+ as required by typecheck-gcc
  • enable compiler warnings also for release builds

Testing if this works before merging #1592.

@mention-bot
Copy link

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @sieben and @jactry to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 73.801% when pulling 64083bc on MarcelRaad:travis_typecheck into 651e04c on curl:master.

- switch debug and release configurations so that we get an optimized
  build with GCC 4.3+ as required by typecheck-gcc
- enable warnings-as-errors for release builds
  (which have warnings disabled)
@MarcelRaad
Copy link
Member Author

When switching debug and release and enabling warnings for release, the warnings showed up in the build log, but the build was green anyway. Testing --enable-werror for release now (without --enable-warnings).

@MarcelRaad
Copy link
Member Author

Ah, as the warnings happen to be in a test, for which --enable-werror has no effect, the build still succeeds.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 73.777% when pulling 423d0e4 on MarcelRaad:travis_typecheck into 651e04c on curl:master.

@MarcelRaad
Copy link
Member Author

So this is the version I'd like to merge. It would at least error out on typecheck-gcc warnings (and other warnings enabled by default) in libcurl and the curl tool.

@MarcelRaad MarcelRaad deleted the travis_typecheck branch June 21, 2017 10:29
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants