Skip to content

http: gcc 14 compiler warning on mac arm64 (cmake, unity) #14168

New issue
New issue
Closed
Closed
http: gcc 14 compiler warning on mac arm64 (cmake, unity)#14168
Labels
build
@vszakats

Description

@vszakats
vszakats
opened on Jul 12, 2024 · edited by vszakats

I did this

Built curl-for-win with gcc for mac (arm64), and this compiler warning happened:

curl/lib/http.c: In function 'Curl_add_custom_headers':
curl/lib/http.c:1528:42: warning: '%s' directive argument is null [-Wformat-overflow=]
 1528 |             result = Curl_dyn_addf(req, "%s\r\n", compare);
      |                                          ^~

https://github.com/curl/curl-for-win/actions/runs/9906570816/job/27368394282#step:3:4688

I expected the following

No warnings.

curl/libcurl version

master f94aa3d

operating system

macOS 14 arm64 GHA runner

Activity

vszakats
added
build
on Jul 12, 2024
bagder

bagder commented on Jul 19, 2024

@bagder
bagder
on Jul 19, 2024
Member

That's a silly warning for us since a NULL there is not a problem.

But also: how is it NULL there?

bagder

bagder commented on Aug 2, 2024

@bagder
bagder
on Aug 2, 2024
Member

I build with gcc 14 locally on my x86_64 debian and this is not a warning I see. Does it only happen on arm64? That seems weird.

How about just silence the (false positive) warning for that compiler + platform combo?

vszakats

vszakats commented on Aug 2, 2024

@vszakats
vszakats
on Aug 2, 2024
MemberAuthor

Are you building with cmake/unity=on?

vszakats

vszakats commented on Aug 2, 2024

@vszakats
vszakats
on Aug 2, 2024
MemberAuthor

Good question regarding the CPU. There is no Intel gcc test in CI, but could replicate it locally:

curl/lib/http.c: In function 'Curl_add_custom_headers':
curl/lib/http.c:1528:42: warning: '%s' directive argument is null [-Wformat-overflow=]
 1528 |             result = Curl_dyn_addf(req, "%s\r\n", compare);
      |                                          ^~

cmake:

cmake -B _x64-mac-sys-bld -Wno-dev -DCMAKE_BUILD_TYPE=Release 
-DCMAKE_OSX_DEPLOYMENT_TARGET=10.9 -DCMAKE_INSTALL_MESSAGE=NEVER 
-DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_C_COMPILER=gcc-14 
-DCMAKE_IGNORE_PREFIX_PATH=/usr/local 
-DCMAKE_OSX_SYSROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk 
-DCMAKE_C_COMPILER_TARGET=x86_64-apple-darwin -DBUILD_TESTING=OFF 
-DENABLE_WEBSOCKETS=ON -DENABLE_THREADED_RESOLVER=ON 
-DZLIB_INCLUDE_DIR= -DCURL_BROTLI=OFF -DCURL_ZSTD=OFF -DCURL_USE_OPENSSL=ON 
-DOPENSSL_ROOT_DIR=.../libressl/_x64-mac-sys/usr -DCURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG=ON 
-DHAVE_BORINGSSL=0 -DHAVE_AWSLC=0 -DHAVE_SSL_CTX_SET_QUIC_METHOD=1 -DCURL_USE_SECTRANSP=OFF 
-DCURL_DISABLE_SRP=ON -DCURL_USE_LIBSSH=OFF -DCURL_USE_LIBSSH2=OFF -DUSE_NGHTTP2=OFF 
-DUSE_NGHTTP3=OFF -DUSE_NGTCP2=OFF -DUSE_LIBIDN2=OFF -DUSE_APPLE_IDN=ON 
-DCURL_USE_LIBPSL=OFF -DENABLE_CURL_MANUAL=ON -DBUILD_LIBCURL_DOCS=OFF 
-DSHARE_LIB_OBJECT=ON --no-warn-unused-cli -DCMAKE_UNITY_BUILD=ON -DBUILD_CURL_EXE=ON 
-DBUILD_STATIC_CURL=ON -DCURL_CA_PATH=none -DCURL_CA_BUNDLE=none -DBUILD_SHARED_LIBS=ON 
-DBUILD_STATIC_LIBS=ON -DCURL_HIDDEN_SYMBOLS=ON -DCMAKE_RC_FLAGS= '-DCMAKE_C_FLAGS=  
-mmacosx-version-min=10.9 -fno-omit-frame-pointer -fcf-protection=full -fvisibility=hidden 
-fno-unwind-tables -fno-asynchronous-unwind-tables -fno-ident   -DHAS_ALPN ' 
'-DCMAKE_EXE_LINKER_FLAGS= -v  -Wl,-map,curl.map ' 
'-DCMAKE_SHARED_LINKER_FLAGS= -v  -Wl,-map,libcurl.map '

not minimal, but straight of a curl-for-win with curl + libressl only:

export CW_CONFIG=test-x64-gcc-mac; export CW_CCSUFFIX='-14'

With riscv64 Linux and gcc 14 this warning is not happening.

Instead there is this one, where the code look correct but non-trivial for a compiler to see:

/home/runner/work/curl-for-win/curl-for-win/curl/lib/smb.c: In function 'smb_connection_state':
/home/runner/work/curl-for-win/curl-for-win/curl/lib/smb.c:895:5: warning: 'memcpy' offset [74, 80] from the object at 'buf' is out of the bounds of referenced subobject 'bytes' with type 'char[1]' at offset 73 [-Warray-bounds=]
  895 |     memcpy(smbc->challenge, nrsp->bytes, sizeof(smbc->challenge));
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/curl-for-win/curl-for-win/curl/lib/smb.c:130:8: note: subobject 'bytes' declared here
  130 |   char bytes[1];
      |        ^~~~~
vszakats

vszakats commented on Aug 2, 2024

@vszakats
vszakats
on Aug 2, 2024
MemberAuthor

Confirmed this is unity-specific, and thus needs cmake.

bagder

bagder commented on Aug 17, 2024

@bagder
bagder
on Aug 17, 2024
Member

But we don't see these in any CI do we?

vszakats

vszakats commented on Aug 17, 2024

@vszakats
vszakats
on Aug 17, 2024 · edited by vszakats
MemberAuthor

It's on the curl-for-win daily CI run.

Edit: no sorry, not the daily but the other, extended workflow.

bagder

bagder commented on Aug 19, 2024

@bagder
bagder
on Aug 19, 2024 · edited by bagder
Member

-Wformat-overflow is not a warning that we want enabled as it does not help us. It can only bring us false positives:

Warn about calls to formatted input/output functions such as sprintf and vsprintf that might overflow the destination buffer

We explicitly never use sprintf and vsprintf in code (they are banned by checksrc).

I will file a PR to remove it.

bagder
added a commit that references this issue on Aug 19, 2024

build: use -Wno-format-overflow

f183403
bagder
mentioned this on Aug 19, 2024
bagder
closed this as completedin 145f87bon Aug 19, 2024
vszakats
added a commit that references this issue on Aug 19, 2024

build: use -Wno-format-overflow

145f87b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    build

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @bagder@vszakats

      Issue actions
        http: gcc 14 compiler warning on mac arm64 (cmake, unity) · Issue #14168 · curl/curl