-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
build: add Debug, TrackMemory, ECH to feature list #14096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe also this for autotools, though it was explicitly deleted when adding ECH support in a362962: iff --git a/configure.ac b/configure.ac
index 6c9a3f1f1..e89d97ae9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4817,6 +4817,10 @@ else
AC_MSG_RESULT([no])
fi
+if test "x$ECH_ENABLED" = "x1"; then
+ SUPPORT_FEATURES="$SUPPORT_FEATURES ECH"
+fi
+
if test ${ac_cv_sizeof_curl_off_t} -gt 4; then
if test ${ac_cv_sizeof_off_t} -gt 4 -o \
"$curl_win32_file_api" = "win32_large_files"; then |
Why are curl/tests/libtest/test1013.pl Lines 48 to 49 in fa2c575
or curl-debug not expected to know about them: 2f3d520 ?
Do we still need |
I wonder if that perhaps was a mistake? Or perhaps done so because there is no corresponding internal feature bit for ECH.
I believe the thinking was that they are developer-oriented, not end user oriented. But since they are exposed by curl itself anyway I think that logic is flawed....
Correct. We removed support for that in 7.82.0 |
Oops, it is added as a feature name though. |
Hit a bump where configure thinks TrackMemory isn't supported, Happening with msys/cygwin autotools builds. It's caused by configure first checking for the intent of enabling TrackMemory and setting the CMake doesn't have the extra check. Either it can be deleted, or if useful, fix the place defining |
It seems that since that original commit in 2009-06-09, the second check performed in Unless I'm misreading/missing something. |
It fails on this platform, despite linking statically. Ref: 96a1a05 curl#14096
Also:
remove stray
ECH
andHTTPSRR
from cmake protocol list.stop excluding
Debug
andTrackMemory
intest1013.pl
.configure: delete
CURL_CHECK_CURLDEBUG
check.Ref: 065047d
This check was effectively doing nothing, except disabling
--enable-curldebug
incurl-config
forCygwin/MSYS/cegcc/OS2/AIX targets with c-ares enabled.
Closes #14096
CharConv
references from tests.