winbuild: fix PE version info debug flag #13739
Conversation
- Only set PE file flag VS_FF_DEBUG if curl.exe and libcurl.dll were built with winbuild option DEBUG=yes which builds with debug info. VS_FF_DEBUG is a PE flag (Portable Executable file flag - dll, exe, etc) that indicates the file contains or was built with debug info. Prior to this change when winbuild was used to build curl, curl.exe and libcurl.dll always had VS_FF_DEBUG set, regardless of build option DEBUG=yes/no, due to some bad logic. Closes #xxxx
|
Completely unrelated – just noticed while looking – that |
Those defines can be removed. Do you want to make a pr for it? if not i can do it later. |
It's better if you do it – I have no ways to test winbuild mods. |
- Remove all instances in the makefile of compiler option /DWIN32. This is a follow-up to e9a7d4a which replaced all defined(WIN32) checks with defined(_WIN32), since only the latter is automatically defined by all compilers for Windows builds. Bug: curl#13739 (comment) Reported-by: Viktor Szakats Closes #xxxx
|
ok #13742 |
- Remove all instances in the makefile of compiler option /DWIN32. This is a follow-up to e9a7d4a which replaced all defined(WIN32) checks with defined(_WIN32) in the codebase, since only the latter is automatically defined by all compilers for Windows builds. Bug: #13739 (comment) Reported-by: Viktor Szakats Closes #13742
VS_FF_DEBUG is a PE flag (Portable Executable file flag - dll, exe, etc) that indicates the file contains or was built with debug info.
Prior to this change when winbuild was used to build curl, curl.exe and libcurl.dll always had VS_FF_DEBUG set, regardless of build option DEBUG=yes/no, due to some bad logic.
Closes #xxxx
The bad logic defined DEBUGBUILD=0 for resource file compilations that did not contain debug information. Those resource files then guarded the VS_FF_DEBUG flag with defined(DEBUGBUILD) which of course is defined even when DEBUGBUILD is 0. Even if that was fixed it still wouldn't make sense because winbuild doesn't define DEBUGBUILD for building curl or libcurl --only for building their respective resource files-- so I moved to defining and checking _DEBUG instead for resource file compilations.
caught while reviewing #13730