Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbedTLS: Implemented CURLOPT_SSL_CIPHER_LIST option #13442

Closed
wants to merge 1 commit into from

Conversation

jan2000
Copy link
Contributor

@jan2000 jan2000 commented Apr 22, 2024

Use a lookup list to set the cipher suites, allowing the ciphers to be set by either openssl or IANA names.

To keep the binary size of the lookup list down we compress each entry in the cipher list down to 2 + 6 bytes using the C preprocessor.

@github-actions github-actions bot added tests CI Continuous Integration labels Apr 22, 2024
lib/vtls/mbedtls.c Outdated Show resolved Hide resolved
lib/vtls/mbedtls.c Outdated Show resolved Hide resolved
lib/vtls/mbedtls.c Show resolved Hide resolved
lib/vtls/mbedtls.c Outdated Show resolved Hide resolved
lib/vtls/cipher_suite.c Outdated Show resolved Hide resolved
@jan2000 jan2000 force-pushed the mbedtls-add-ssl-cipher-list branch from 326d17b to 8ed1d8b Compare April 22, 2024 21:52
@bagder
Copy link
Member

bagder commented Apr 23, 2024

Ah, the test case got a merge conflict now as another commit unfortunately was merged that used the same number.

@jan2000 jan2000 force-pushed the mbedtls-add-ssl-cipher-list branch from 8ed1d8b to ac18150 Compare April 23, 2024 13:58
@jan2000
Copy link
Contributor Author

jan2000 commented Apr 23, 2024

Ok, I have rebased to latest master and updated to test 3205.

lib/vtls/cipher_suite.c Outdated Show resolved Hide resolved
vszakats added a commit to vszakats/curl that referenced this pull request Apr 23, 2024
Pointed-out-by: jan2000 on github
Ref: curl#13442 (comment)
Closes #xxxxx
Use a lookup list to set the cipher suites, allowing the
ciphers to be set by either openssl or IANA names.

To keep the binary size of the lookup list down we compress
each entry in the cipher list down to 2 + 6 bytes using the
C preprocessor.
@jan2000 jan2000 force-pushed the mbedtls-add-ssl-cipher-list branch from ac18150 to 0a38c82 Compare April 23, 2024 15:54
vszakats added a commit that referenced this pull request Apr 24, 2024
Avoid clashing static function names by namespacing them.

Pointed-out-by: Jan Venekamp
Ref: #13442 (comment)
Closes #13450
@bagder bagder closed this in fba9afe Apr 24, 2024
@bagder
Copy link
Member

bagder commented Apr 24, 2024

Thanks!

@jan2000 jan2000 deleted the mbedtls-add-ssl-cipher-list branch May 4, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tests
Development

Successfully merging this pull request may close these issues.

None yet

3 participants