New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbedTLS: Implemented CURLOPT_SSL_CIPHER_LIST option #13442
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan2000
commented
Apr 22, 2024
bagder
reviewed
Apr 22, 2024
bagder
reviewed
Apr 22, 2024
jan2000
force-pushed
the
mbedtls-add-ssl-cipher-list
branch
from
April 22, 2024 21:52
326d17b
to
8ed1d8b
Compare
Ah, the test case got a merge conflict now as another commit unfortunately was merged that used the same number. |
jan2000
force-pushed
the
mbedtls-add-ssl-cipher-list
branch
from
April 23, 2024 13:58
8ed1d8b
to
ac18150
Compare
Ok, I have rebased to latest master and updated to test 3205. |
vszakats
reviewed
Apr 23, 2024
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 23, 2024
Pointed-out-by: jan2000 on github Ref: curl#13442 (comment) Closes #xxxxx
Use a lookup list to set the cipher suites, allowing the ciphers to be set by either openssl or IANA names. To keep the binary size of the lookup list down we compress each entry in the cipher list down to 2 + 6 bytes using the C preprocessor.
jan2000
force-pushed
the
mbedtls-add-ssl-cipher-list
branch
from
April 23, 2024 15:54
ac18150
to
0a38c82
Compare
bagder
approved these changes
Apr 24, 2024
vszakats
added a commit
that referenced
this pull request
Apr 24, 2024
Avoid clashing static function names by namespacing them. Pointed-out-by: Jan Venekamp Ref: #13442 (comment) Closes #13450
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a lookup list to set the cipher suites, allowing the ciphers to be set by either openssl or IANA names.
To keep the binary size of the lookup list down we compress each entry in the cipher list down to 2 + 6 bytes using the C preprocessor.