Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mqtt: when Curl_xfer_recv returns error, don't use nread #13418

Closed
wants to merge 1 commit into from
Closed

mqtt: when Curl_xfer_recv returns error, don't use nread #13418

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Apr 19, 2024

A returned error code makes other return value unreliable, and in this case potentially uninitialized. On error, do not read other return values like the nread counter.

Spotted by CodeSonar

@bagder
mqtt: when Curl_xfer_recv returns error, don't use nread
5a49ca1 
A returned error code makes other return value unreliable, and in this
case potentially uninitialized. On error, do not read other return
values like the nread counter.

Spotted by CodeSonar
@bagder bagder added the MQTT label Apr 19, 2024
@bagder bagder closed this in 123d3ef Apr 19, 2024
@bagder bagder deleted the bagder/mqtt-uninit-var branch April 19, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icing icing icing approved these changes

Assignees
No one assigned
Labels
MQTT
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @icing