Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

result of Curl_bufq_cread was not used #13398

Closed
wants to merge 2 commits into from
Closed

result of Curl_bufq_cread was not used #13398

wants to merge 2 commits into from

Conversation

MonkeybreadSoftware
Copy link
Contributor

We pass back the result to the caller.

@MonkeybreadSoftware
result of Curl_bufq_cread was not used
82d81b5 
We pass back the result to the caller.
@github-actions github-actions bot added the SMTP label Apr 17, 2024
@MonkeybreadSoftware MonkeybreadSoftware mentioned this pull request Apr 17, 2024
Closed
bagder
bagder reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the cr_eob_read function should instead be made to return result;. Not return early. That looks more like what was intended.

@icing what do you think?

@MonkeybreadSoftware
Update smtp.c
e494ba1 
Changed to return result on the end.
@MonkeybreadSoftware
Copy link
Contributor Author

Yes, otherwise we would miss the last lines in the functions.

@icing
Copy link
Contributor

icing commented Apr 17, 2024

This looks correct.

@bagder bagder closed this in 4746b83 Apr 17, 2024
@bagder
Copy link
Member

bagder commented Apr 17, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
SMTP
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MonkeybreadSoftware @icing @bagder