Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbedtls: fix building with v3 in CMake Unity mode #13377

Closed
wants to merge 1 commit into from
Closed

mbedtls: fix building with v3 in CMake Unity mode #13377

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Apr 15, 2024 •
edited

Before this patch the internal feature detection macro
HAS_MBEDTLS_RESULT_CODE_BASED_FUNCTIONS was defined in three files,
with an incomplete logic in one of them. In Unity mode that spilled
into another source file and broke the build.

Closes #13377

@vszakats
mbedtls: fix building with v3 in CMake Unity mode
de4b55c 
Before this patch the internal feature detection macro
`HAS_MBEDTLS_RESULT_CODE_BASED_FUNCTIONS` was defined in three
files, with an incomplete logic in one of them.

Closes #xxxxx
@vszakats vszakats closed this in 3774b8a Apr 16, 2024
@vszakats vszakats deleted the mbedtls-3-unity branch April 16, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
cmake TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vszakats @bagder