Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: forward USE_LIBRTMP option to C #13364

Closed
wants to merge 1 commit into from

Conversation

talregev
Copy link
Contributor

Define in c USE_LIBRTMP if user request it from the cmake.

@talregev talregev changed the title Define in c USE_LIBRTMP if user request it from the cmake. [cmake] Define in c USE_LIBRTMP if user request it from the cmake. Apr 14, 2024
@talregev
Copy link
Contributor Author

Maybe add this feature to here:
https://curl.se/libcurl/c/curl_version_info.html

@bagder
Copy link
Member

bagder commented Apr 14, 2024

Maybe add this feature to here: https://curl.se/libcurl/c/curl_version_info.html

Ah yes, looks like a total oversight!

bagder added a commit that referenced this pull request Apr 15, 2024
Ref: #13364 (comment)
Reported-by: talregev on github
@vszakats

This comment was marked as off-topic.

bagder added a commit that referenced this pull request Apr 15, 2024
Ref: #13364 (comment)
Reported-by: talregev on github
bagder added a commit that referenced this pull request Apr 15, 2024
Ref: #13364 (comment)
Reported-by: talregev on github
Closes #13368
@vszakats vszakats changed the title [cmake] Define in c USE_LIBRTMP if user request it from the cmake. cmake: forward USE_LIBRTMP option to C Apr 15, 2024
@talregev
Copy link
Contributor Author

I agree that you can add your suggestion in next PR.
Thank you for the review!

@vszakats vszakats closed this in 6eb9e65 Apr 15, 2024
@vszakats
Copy link
Member

Thank you @talregev, merged now.

vszakats added a commit to vszakats/curl that referenced this pull request Apr 15, 2024
Add CMake option `USE_LIBRTMP`. Disabled by default.

This library requires OpenSSL TLS-backend when linked statically.

Follow-up to 6eb9e65 curl#13364
Closes curl#13373
@talregev talregev deleted the TalR/librtmp branch April 15, 2024 21:38
vszakats added a commit that referenced this pull request Apr 16, 2024
Add CMake option `USE_LIBRTMP`. Disabled by default.

This library requires OpenSSL TLS-backend when linked statically.

Follow-up to 6eb9e65 #13364
Closes #13373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants