Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: merge ENABLE_QUIC C macro into USE_HTTP3 #13352

Closed
wants to merge 1 commit into from
Closed

lib: merge ENABLE_QUIC C macro into USE_HTTP3 #13352

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Apr 11, 2024 •
edited

Before this patch lib/curl_setup.h defined these two macros right
next to each other, then the source code used them interchangeably.

After this patch, USE_HTTP3 guards all HTTP/3 / QUIC features.
(Like USE_HTTP2 does for HTTP/2.) ENABLE_QUIC is no longer used.

This patch doesn't change the way HTTP/3 is enabled via autotools
or CMake. Builders who enabled HTTP/3 manually by defining both of
these macros via CPPFLAGS can now delete -DENABLE_QUIC.

Closes #13352

I could not spot the difference between the meaning of these two macros
in context of curl's HTTP/3 support. Let me know if I missed something.

@vszakats
lib: merge ENABLE_QUIC C macro into USE_HTTP3
c778484 
They were defined right next to each other, and used interchangeably
afterwards.

Closes #xxxxx
@vszakats vszakats added build HTTP/3 h3 or quic related tidy-up labels Apr 11, 2024
@talregev
Copy link
Contributor

There is a several ways to build http3 with curl.
Can you elaborate about each of one, if it will not effect them after your patch?
I am more interested if you can able to compile openssl + nghttp3 to have http3 feature inside curl after your patch?

@vszakats
Copy link
Member Author

vszakats commented Apr 12, 2024 •
edited

My patch doesn't change how these features are enabled / selected.

OpenSSL + nghttp3 can be enabled the same way as before:
CMake: -DCURL_USE_OPENSSL=ON -DOPENSSL_ROOT_DIR=<path> -DUSE_OPENSSL_QUIC=ON
autotools: --with-openssl=<path> --with-openssl-quic

(If someone was using ENABLE_QUIC + USE_HTTP3 as raw CPPFLAGS to enable HTTP/3, ENABLE_QUIC no longer needs to be passed after this patch.)

@talregev
Copy link
Contributor

Thank you for clearing it up!

@vszakats vszakats closed this in 49f83c3 Apr 13, 2024
@vszakats vszakats deleted the quic-macro branch April 13, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build HTTP/3 h3 or quic related tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vszakats @talregev @bagder