quic: fixup duplicate static function name (for cmake unity) #13332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CMake Unity builds break when reusing a static function (or other symbol) What would be a good long-term solution to avoid this? I can add a complete curl-for-win build as part of the curl CI. It would be |
vszakats
changed the title
Visible in daily curl-for-win builds: https://github.com/curl/curl-for-win/actions/runs/8621925870 ``` lib/vquic/curl_ngtcp2.c:1916:12: error: redefinition of 'ossl_new_session_cb' static int ossl_new_session_cb(SSL *ssl, SSL_SESSION *ssl_sessionid) ^ lib/vtls/openssl.c:2978:12: note: previous definition is here static int ossl_new_session_cb(SSL *ssl, SSL_SESSION *ssl_sessionid) ^ ``` https://github.com/curl/curl-for-win/actions/runs/8621925870/job/23631885439#step:3:6965 Closes #xxxxx
vszakats
force-pushed
the
fixup-static-func-collision
branch
from
35bebd1
to
317a3db
Compare
|
Bringing curl-for-win to curl CI in this PR: #13335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visible in daily curl-for-win builds:
https://github.com/curl/curl-for-win/actions/runs/8621925870
https://github.com/curl/curl-for-win/actions/runs/8621925870/job/23631885439#step:3:6965
Follow-up to 3210101 #13172
Closes #13332