New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projects: drop MSVC project files for recent versions #13311
Conversation
We encourage users to generate visual studio project files using CMake. We keep project files in git for ancient visual studio versions that cmake cannot generate files for, but we no longer ship the project files in the tarballs.
@MarcelRaad and @jay thoughts? |
Everything curl is now correspondingly mentioning the "generate with cmake" way: https://everything.curl.dev/build/windows.html |
The documentation needs to be updated. Also I would include the generated VC10-12 with the tarball if the tarball can still be reproducible. I forgot we stopped doing that. |
.. also add --help and /? as aliases for -help and /? options
- explain user must run generate.bat to generate legacy versions - explain user must use cmake to generate later versions
nm. I removed the dead code for VC14 and changed the README to explain that generate.bat must be run to generate the legacy versions of Visual Studio project files and cmake must be run to generate later versions of Visual Studio project files. |
'VisualStudioSolution, VS2017, Debug, x86, Schannel, Build-only' AppVeyor job needs update
Ah yes, appveyor uses |
Strong vote for the latter. It would also serve as an example for how to do that. |
The only reason I used Visual Studio 2017 for that build in #3941 is that it was the latest version for which Visual Studio solution files existed back then. Not sure if switching it to CMake would make much sense as we already have a lot of CMake builds. I'd rather switch it to VS 2013, which is also the oldest version supported by Appveyor. Otherwise, we have no Visual Studio solution build at all in CI, right? Or did I misunderstand something and the plan was to turn it into something special? |
An option to keep this job useful is moving it to VC 12 (= Visual Studio 2013) (from 14.10 aka Visual Studio 2017). This compiler version isn't tested at the moment and Here's a translation table for the confusing MSVC version numbering schemes:
|
Tested the VC12 approach here, with success: Patch: --- a/appveyor.yml
+++ b/appveyor.yml
@@ -230,12 +230,12 @@ environment:
TESTING: 'OFF'
ENABLE_UNICODE: 'yes'
# generated VisualStudioSolution-based builds
- - job_name: 'VisualStudioSolution, VS2017, Debug, x86, Schannel, Build-only'
- APPVEYOR_BUILD_WORKER_IMAGE: 'Visual Studio 2017'
+ - job_name: 'VisualStudioSolution, VS2013, Debug, x86, Schannel, Build-only'
+ APPVEYOR_BUILD_WORKER_IMAGE: 'Visual Studio 2015'
BUILD_SYSTEM: VisualStudioSolution
PRJ_CFG: 'DLL Debug - DLL Windows SSPI - DLL WinIDN'
TESTING: 'OFF'
- VC_VERSION: VC14.10
+ VC_VERSION: VC12
# autotools-based builds (NOT mingw cross-compiling, but msys2 native)
- job_name: 'autotools, msys2, Debug, x86_64, no Proxy, no SSL'
APPVEYOR_BUILD_WORKER_IMAGE: 'Visual Studio 2017' |
aka Visual Studio 2013.
We encourage users to generate visual studio project files using CMake.
We keep project files in git for ancient visual studio versions that cmake cannot generate files for, but we no longer ship the project files in the tarballs.
(alternative take to #13296)