Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist: do not require Perl in maketgz #13310

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Apr 7, 2024

Perl remains required for the tarball build process.

Follow-up to 860cd5f #13299
Closes #13310

@vszakats vszakats added the build label Apr 7, 2024
@bagder
Copy link
Member

bagder commented Apr 8, 2024

I'm fine with this. But note that maketgz should be invoked after a proper configure + make run, which requires perl present - so that the tool_hugehelp.c file gets generated properly. Thus, we can't remove perl from the #13250 docker image.

@vszakats
Copy link
Member Author

vszakats commented Apr 8, 2024

Yes, Perl is here to stay, just this one-liner was easy replace with shell code.
(And another one in #13307 / 7c425cb)

@vszakats vszakats closed this in 2c4f836 Apr 8, 2024
@vszakats vszakats deleted the maketgz-no-perl branch April 8, 2024 09:29
@vszakats vszakats added the dist label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants