OS400: fix shellcheck warnings in scripts #13309
Closed
+106
−92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$()
instead of backticks, and re-arrange double-quotes inside.|| exit 1
tocd
calls. (could be dropped by usingset -eu
.)-n
to a fewif
s.{} >
(as shellcheck recommended).-ot
feature.$(expr \
,$(dirname \
)Also enable CI checks for OS/400 shell scripts.
Ref: #13307
Closes #13309
Added one FIXME ininitscript.sh
where there is a single use of a non-POSIXexpression
[ "${1}" -ot "${2}" ]
causing a warning. We can fix this by bumpingthe shebangs to bash, or come up with a POSIX alternative.
/cc @monnerat