New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: add shellcheck job and fix warnings, shell tidy-ups #13307
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
GHA: add shellcheck job and fix fallouts, tidy-up
GHA: add shellcheck job and fix warnings, tidy-up
Apr 7, 2024
bagder
approved these changes
Apr 8, 2024
bagder
reviewed
Apr 8, 2024
vszakats
changed the title
GHA: add shellcheck job and fix warnings, tidy-up
GHA: add shellcheck job and fix warnings, tidy-ups
Apr 8, 2024
vszakats
changed the title
GHA: add shellcheck job and fix warnings, tidy-ups
GHA: add shellcheck job and fix warnings, shell tidy-ups
Apr 8, 2024
vszakats
added a commit
that referenced
this pull request
Apr 11, 2024
- use `$()` instead of backticks, and re-arrange double-quotes inside. - add missing `|| exit 1` to `cd` calls. (could be dropped by using `set -eu`.) - add `-n` to a few `if`s. - shorten redirections by using `{} >` (as shellcheck recommended). - silence warnings where variables were detected as unused (SC2034). - a couple misc updates to silence warnings. - switch to bash shebang for `-ot` feature. - split two lines to unbreak syntax highlighting in my editor. (`$(expr \`, `$(dirname \`) Also enable CI checks for OS/400 shell scripts. Ref: #13307 Closes #13309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13307
set -eu
, fix shellcheck, make reproducible and smaller tarballs #13299MacOSX-Framework
might use an overhaul. build: remove MacOSX-Framework script #13313Without whitespace changes: https://github.com/curl/curl/pull/13307/files?w=1