Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: check fseeko after detecting HAVE_FILE_OFFSET_BITS #13264

Closed
wants to merge 2 commits into from
Closed

cmake: check fseeko after detecting HAVE_FILE_OFFSET_BITS #13264

wants to merge 2 commits into from

Conversation

SirLynix
Copy link
Contributor

@SirLynix SirLynix commented Apr 2, 2024 •
edited

On Android, fseeko is defined as is (I omitted other functions for clarity):

/* See https://android.googlesource.com/platform/bionic/+/master/docs/32-bit-abi.md */
#if defined(__USE_FILE_OFFSET64)

#if __ANDROID_API__ >= 24
int fseeko(FILE* _Nonnull __fp, off_t __offset, int __whence) __RENAME(fseeko64) __INTRODUCED_IN(24);
#endif /* __ANDROID_API__ >= 24 */

#else
int fseeko(FILE* _Nonnull __fp, off_t __offset, int __whence);

#if __ANDROID_API__ >= 24
int fseeko64(FILE* _Nonnull __fp, off64_t __offset, int __whence) __INTRODUCED_IN(24);
#endif /* __ANDROID_API__ >= 24 */

#endif

Which means that on Android 32bits (armv7), fseeko is only available in 32bits mode, if __USE_FILE_OFFSET64 (_FILE_OFFSET_BITS=64) is set then fseeko is not available.

CMake detects fseeko as available because _FILE_OFFSET_BITS=64 is not yet defined when it tests for this function existence, but then it defines _FILE_OFFSET_BITS=64 which makes fseeko unavailable and fails compilation:

/home/runner/.xmake/cache/packages/2404/l/libcurl/8.6.0/source/lib/formdata.c:794:10: error: call to undeclared function 'fseeko'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  return fseeko(stream, (off_t)offset, whence);
         ^
/home/runner/.xmake/cache/packages/2404/l/libcurl/8.6.0/source/lib/formdata.c:794:10: note: did you mean 'fseek'?
/home/runner/work/xmake-repo/xmake-repo/android-ndk-r26b/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/stdio.h:215:5: note: 'fseek' declared here
int fseek(FILE* _Nonnull __fp, long __offset, int __whence);
    ^

A simple fix is to test for fseeko existence after testing HAVE_FILE_OFFSET_BITS and especially after

  set(CMAKE_REQUIRED_FLAGS "-D_FILE_OFFSET_BITS=64")

tested here

Fix #12086 for good

vszakats
vszakats reviewed Apr 2, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@vszakats vszakats changed the title CMake: check fseeko after detecting HAVE_FILE_OFFSET_BITS cmake: check fseeko after detecting HAVE_FILE_OFFSET_BITS Apr 2, 2024
@SirLynix SirLynix mentioned this pull request Apr 3, 2024
Closed
SirLynix and others added 2 commits April 7, 2024 11:16
@SirLynix
CMake: check fseeko after detecting HAVE_FILE_OFFSET_BITS
2f5a331
@SirLynix @vszakats
Update CMakeLists.txt
dcda7ae 
Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
@bagder bagder closed this in 6b86471 Apr 8, 2024
@bagder
Copy link
Member

bagder commented Apr 8, 2024

Thanks!

@SirLynix SirLynix deleted the patch-1 branch April 8, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vszakats vszakats vszakats left review comments

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8.4.0 fails to build on cross-compiled android ARM
3 participants
@SirLynix @bagder @vszakats