New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] libcurl does not finish CURLOPT_UPLOAD request after a connection lost without data tranfer #13260
Comments
- a transfer with a completed download that is still uploading needs to check the connection state when it is PAUSEd, since connection close/errors would otherwise go unnoticed. - refs curl#13260
I tried to reproduce the situation in a curl test case, so that we can avoid regressions on this in the future. The case where I could reproduce a stall with the server going aways is: A transfer
If this is indeed the situation that you are in with the |
Could you verify if #13271 addresses your issue? |
Sure, will do and report soon. |
The issue is still present with a patch on top of the master (60971d6). Curl's output:
|
Sure. I can confirm that this version fixes the problem. |
Thanks, with the new test case in place, I hope we can avoid stumbling into this again in the future. |
I did this
There was an issue in Tarantool 1 due to regression in libcurl (#11769), it was reported on 23 Aug, 2023. Issue was fixed in upstream on 4 Sept, 2023 and fix was confirmed by our tests for Tarantool. Unfortunately, this fix was ruined by refactoring made in commit d7b6ce6 ("lib: replace readwrite with write_resp") [3] on 1 Dec 2023, and now it is reproduced again.
I expected the following
curl/libcurl version
8.6.0+
operating system
uname -a
: Linux pony 6.5.0-26-generic #26~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Mar 12 10:22:43 UTC 2 x86_64 x86_64 x86_64 GNU/LinuxUbuntu 22.04.4 LTS
Footnotes
https://github.com/tarantool/tarantool/issues/9086 ↩ ↩2
The text was updated successfully, but these errors were encountered: