Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl_sha512_256: do not use workaround for NetBSD when not needed #13225

Closed
wants to merge 2 commits into from
Closed

curl_sha512_256: do not use workaround for NetBSD when not needed #13225

wants to merge 2 commits into from

Conversation

Karlson2k
Copy link
Contributor

@Karlson2k
Copy link
Contributor Author

@mkauf, could you, please, try it on NetBSD?

riastradh
riastradh reviewed Mar 28, 2024
View reviewed changes
lib/curl_sha512_256.c Outdated Show resolved Hide resolved
lib/curl_sha512_256.c Outdated Show resolved Hide resolved
@Karlson2k Karlson2k force-pushed the sha512_256_update_netbsd_02 branch 2 times, most recently from e6a9afb to 855803f Compare March 29, 2024 08:49
@mkauf
Copy link
Contributor

mkauf commented Mar 30, 2024

@mkauf, could you, please, try it on NetBSD?

Done, it works on NetBSD 9.3 (test 1615 succeeds).

@bagder bagder closed this in 4a98db3 Mar 30, 2024
@bagder
Copy link
Member

bagder commented Mar 30, 2024

Thanks!

@Karlson2k Karlson2k deleted the sha512_256_update_netbsd_02 branch March 30, 2024 22:53
@Karlson2k
Copy link
Contributor Author

Thanks for the detailed information, @riastradh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riastradh riastradh riastradh left review comments

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
cryptography
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Karlson2k @mkauf @bagder @riastradh