Fix incomplete/broken nghttp2 build support on Windows #1321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
the flag name should be WITH_NGHTTP2, according to the current naming scheme. An external dep should always use "with" instead of "enable". The previous flag ENABLE_NGHTTP2 was kept for the compatibility reasons, so if passed it'll configure shared nghttp2 link as by default
the meaning of "with" was extended to allow shared/static link of nghttp2, the corresponding flags are passed as required by nghttp2.
nghttp2 does not depend on SSL of any kind, so the corresponding conditions are abandoned.
the build folder name is extended with "nghttp2-<dll|static>", as it's done for other libs
the library names are default as produced by the nghttp2 cmake configs.
thanks