Fix detection of OpenSSL 1.1.1 or later in curl_sha512_256.c #13208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same OPENSSL_VERSION_NUMBER comparison as in lib/vtls/openssl.c.
|
/cc @Karlson2k |
|
I made detection according to the OpenSSL documentation. |
|
The version number would be correct as per the current numbering documentation. However, this changed with OpenSSL 3.x - the documentation for OpenSSL 1.x was slightly different: https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_VERSION_NUMBER.html |
bagder
approved these changes
Mar 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same OPENSSL_VERSION_NUMBER comparison as in lib/vtls/openssl.c.
As it stands, builds using an OpenSSL 1.1.0 release fail due to trying to use the unavailable symbol EVP_sha512_256.