Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing xattr fails when protocol is guessed #13205

Closed
ilmari opened this issue Mar 27, 2024 · 1 comment
Closed

Writing xattr fails when protocol is guessed #13205

ilmari opened this issue Mar 27, 2024 · 1 comment
Assignees
@bagder
Labels
cmdline tool

Comments

@ilmari
Copy link

ilmari commented Mar 27, 2024

I did this

❯ curl --location --xattr -o curl.html curl.se
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  8684  100  8684    0     0  78961      0 --:--:-- --:--:-- --:--:-- 78961
Warning: Error setting extended attributes on 'curl.html': Success

I expected the following

The user.xdg.origin.url xattr to be set to the URL including the guessed protocol, i.e. http://curl.se/.

curl/libcurl version

curl 8.5.0 (x86_64-pc-linux-gnu) libcurl/8.5.0 OpenSSL/3.0.13 zlib/1.2.13 brotli/1.0.9 zstd/1.5.4 libidn2/2.3.3 libpsl/0.21.2 (+libidn2/2.3.3) libssh2/1.10.0 nghttp2/1.52.0 librtmp/2.3 OpenLDAP/2.5.13
Release-Date: 2023-12-06, security patched: 8.5.0-2~bpo12+1
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli GSS-API HSTS HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM PSL SPNEGO SSL threadsafe TLS-SRP UnixSockets zstd

operating system

Linux ilmari-thinkpad 6.1.0-13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.55-1 (2023-09-29) x86_64 GNU/Linux
@ilmari
Copy link
Author

ilmari commented Mar 27, 2024

looks like this was broken by #3433

@bagder bagder self-assigned this Mar 28, 2024
bagder added a commit that referenced this issue Mar 28, 2024
@bagder
tool_xattr: "guess" URL scheme if none is provided
93b1c4b 
... when figuring out the source URL to store.

Reported-by: Dagfinn Ilmari Mannsåker
Fixes #13205
@bagder bagder mentioned this issue Mar 28, 2024
Closed
@bagder bagder closed this as completed in 5564751 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
cmdline tool
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tool_xattr: "guess" URL scheme if none is provided curl/curl
2 participants
@ilmari @bagder