Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http/2, http/3, decouple stream state from easy handle #13204

Closed
wants to merge 5 commits into from
Closed

http/2, http/3, decouple stream state from easy handle #13204

wants to merge 5 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Mar 27, 2024 •
edited

  • add convenience functions to hash.h for using a hash with curl_off_t as keys. Use this in h2+h3 connection filters to associate data->id with the internal stream state.
  • changed implementations of all affected connection filters
  • removed h2_ctx* and h3_ctx* from struct HTTP and thus the easy handle
  • solves the problem of attaching "foreign protocol" easy handles during connection shutdown

@github-actions github-actions bot added the tests label Mar 27, 2024
@icing icing mentioned this pull request Mar 27, 2024
Closed
@bagder

This comment was marked as outdated.

Sign in to view
@icing

This comment was marked as resolved.

Sign in to view
@icing
Copy link
Contributor Author

icing commented Apr 9, 2024

Separate hash implementation removed again. Convenience functions added.

@vszakats vszakats mentioned this pull request Apr 9, 2024
Closed
@bagder
Copy link
Member

bagder commented Apr 11, 2024

merge conflicts now after some other merges

@icing
http/2, http/3, decouple stream state from easy handle
faeb123 
- add `Curl_hash_offt` as hashmap between a `curl_off_t` and
  an object. Use this in h2+h3 connection filters to associate
  `data->id` with the internal stream state.
- changed implementations of all affected connection filters
- removed `h2_ctx*` and `h3_ctx*` from `struct HTTP` and thus
  the easy handle
- solves the problem of attaching "foreign protocol" easy handles
  during connection shutdown
@icing
unsinged cast in hash_offt for slot calculation
f12aca3
@icing
hash_offt, remove iterator functionality since unused for now
a5a3e10
@icing
hash_offt, rename internal macro for unity builds
ba063d3
@icing
removing separate hash implementation
8fcacff 
- adding convenience functions to hash.h for curl_off_t keys
- adapting connection filters
@icing
Copy link
Contributor Author

icing commented Apr 11, 2024

curl-for-win fails with:

++ gpg --batch --keyserver-options timeout=15 --display-charset utf-8 --keyid-format 0xlong --verify-options show-primary-uid-only --verify pkg.sig pkg.bin
gpg: can't open signed data 'pkg.bin'
gpg: can't hash datafile: No such file or directory

Anyone has an idea what is going on here? @vszakats ?

@vszakats
Copy link
Member

vszakats commented Apr 11, 2024 •
edited

Package or signature downloads from GitHub failed:

++ curl --disable --user-agent '' --fail --silent --show-error --globoff
  --remote-time --xattr --connect-timeout 15 --max-time 60 --retry 3
  --max-redirs 10 --location --proto-redir =https --output pkg.bin
  https://github.com/rockdaboot/libpsl/releases/download/0.21.5/libpsl-0.21.5.tar.gz
  --output pkg.sig
  https://github.com/rockdaboot/libpsl/releases/download/0.21.5/libpsl-0.21.5.tar.gz.sig
curl: (22) The requested URL returned error: 500
curl: (22) The requested URL returned error: 500
curl: (22) The requested URL returned error: 500
curl: (22) The requested URL returned error: 500

A retry should fix this.

@vszakats
Copy link
Member

Made downloads bail out early with a clear error: curl/curl-for-win@5c09843?w=1

@bagder bagder closed this in c6655f7 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icing @bagder @vszakats