urldata: remove values that are not used depending on compilation settings #13188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
reviewed
Mar 26, 2024
| STRING_SSL_CRLFILE, /* crl file to check certificate */ | ||
| STRING_SSL_ISSUERCERT, /* issuer cert file to check certificate */ | ||
| STRING_SERVICE_NAME, /* Service name */ | ||
| #ifndef CURL_DISABLE_PROXY |
There was a problem hiding this comment.
This is in direct contradiction to the comment above the enum which says:
This enumeration MUST not use conditional directives (#ifdefs)
But: the comment also refers to a (misspelled) source code file that was removed in 821d108, which makes me suspect maybe this comment does not apply anymore?
@monnerat can you fill in some blanks maybe?
There was a problem hiding this comment.
It seems the comment is obsolete: the current test is now based on CURLOPT_*, not on STRING_* anymore.
There was a problem hiding this comment.
@MAntoniak can you perhaps update that comment to reflect reality?
There was a problem hiding this comment.
If I understand correctly just remove it?
…tings. Reduced size of dynamically_allocated_data structure. Reduced number of stored values in enum dupstring and enum dupblob. This affects the reduced array placed in the UserDefined structure.
bagder
approved these changes
Apr 5, 2024
|
Thanks! |
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Apr 7, 2024
Reduced size of dynamically_allocated_data structure. Reduced number of stored values in enum dupstring and enum dupblob. This affects the reduced array placed in the UserDefined structure. Closes curl#13188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced size of dynamically_allocated_data structure.
Reduced number of stored values in enum dupstring and enum dupblob. This affects the reduced array placed in the UserDefined structure.
It is also possible to remove the STRING_SASL_AUTHZID and STRING_BEARER values from the dupstring. However, this requires a separate PR.