Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http, separate response parsing from response action #13134

Closed
wants to merge 6 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Mar 15, 2024

  • move code that triggers on end-of-response into separate function from parsing
  • simplify some headp/headerlen usage
  • add httpversion to SingleRequest to indicate the version of the current response

@github-actions github-actions bot added the tests label Mar 15, 2024
@icing icing force-pushed the http-resp-handling branch 2 times, most recently from 41fa5f3 to 7773b8f Compare March 18, 2024 13:35
@bagder
Copy link
Member

bagder commented Mar 19, 2024

@icing if you could just take a look at the merge conflict...

- remove flags and timestamp from SingleRequest
- add 'exp100' client reader when announcing expectation
- new send flag KEEP_SEND_TIMED to trigger sending on
  timer events
- move code that triggers on end-of-response into separate
  function from parsing
- simplify some headp/headerlen usage
- add `httpversion` to SingleRequest to indicate the version
  of the current response
@icing
Copy link
Contributor Author

icing commented Mar 20, 2024

@icing if you could just take a look at the merge conflict...

All resolved.

@bagder bagder closed this in 0f08b43 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants