Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--libcurl generates an integer for --tls-max #13127

Closed
verhovsky opened this issue Mar 14, 2024 · 0 comments
Closed

--libcurl generates an integer for --tls-max #13127

verhovsky opened this issue Mar 14, 2024 · 0 comments
Assignees
@bagder
Labels
cmdline tool

Comments

@verhovsky
Copy link
Contributor

verhovsky commented Mar 14, 2024 •
edited

I did this

curl example.com --tls-max 1.3 --libcurl -

I expected the following

  curl_easy_setopt(hnd, CURLOPT_SSLVERSION, CURL_SSLVERSION_MAX_TLSv1_3);

or possibly

  curl_easy_setopt(hnd, CURLOPT_SSLVERSION, CURL_SSLVERSION_DEFAULT | CURL_SSLVERSION_MAX_TLSv1_3);

What I actually got:

  curl_easy_setopt(hnd, CURLOPT_SSLVERSION, 458752L);

curl/libcurl version

curl 8.6.0 (aarch64-apple-darwin23.2.0) libcurl/8.6.0 (SecureTransport) OpenSSL/3.2.1 zlib/1.2.12 brotli/1.1.0 zstd/1.5.5 libidn2/2.3.7 libssh2/1.11.0 nghttp2/1.60.0 librtmp/2.3 OpenLDAP/2.6.7
Release-Date: 2024-01-31
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns ldap ldaps mqtt pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli GSS-API HSTS HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz MultiSSL NTLM SPNEGO SSL threadsafe TLS-SRP UnixSockets zstd

operating system

Darwin [redacted] 23.4.0 Darwin Kernel Version 23.4.0: Wed Feb 21 21:44:06 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T8103 arm64 arm Darwin
@verhovsky verhovsky mentioned this issue Mar 14, 2024
Merged
@bagder bagder self-assigned this Mar 14, 2024
bagder added a commit that referenced this issue Mar 14, 2024
@bagder
curl: make --libcurl output better CURLOPT_*SSLVERSION
a60ea6c 
The option is really two enums ORed together, so it needs special
attention to make the code output nice.

Added test 1481 to verify. Both the server and the proxy versions.

Reported-by: Boris Verkhovskiy
Fixes #13127
Closes #
@bagder bagder mentioned this issue Mar 14, 2024
Closed
bagder added a commit that referenced this issue Mar 14, 2024
@bagder
curl: make --libcurl output better CURLOPT_*SSLVERSION
a675a37 
The option is really two enums ORed together, so it needs special
attention to make the code output nice.

Added test 1481 to verify. Both the server and the proxy versions.

Reported-by: Boris Verkhovskiy
Fixes #13127
Closes #13129
@bagder bagder closed this as completed in 4094818 Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
cmdline tool
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

curl: make --libcurl output better CURLOPT_*SSLVERSION curl/curl
2 participants
@bagder @verhovsky