Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A transfer may do several
SingleRequest
s for its success. This happens regularly for authentication, follows and retries on failed connections. The "readwrite()" calls and functions connected to those carried abool *done
parameter to indicate that the currentSingleRequest
is over. This may happen beforeupload_done
ordownload_done
bits ofSingleRequest
are set.The problem with that is now
write_resp()
protocol handlers are invoked in places where thebool *done
cannot be passed up to the caller. Instead of being a bool in the call chain, it needs to become a member ofSingleRequest
, reflecting its state.This PR removes the
bool *done
parameter and adds thedone
bit toSingleRequest
instead. It addsCurl_req_soft_reset()
for using aSingleRequest
in a follow up, clearingdone
and other flags/counters.