Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noticed "* We are completely uploaded and fine" for downloads also #13093

Closed
Karthikdasari0423 opened this issue Mar 9, 2024 · 2 comments
Closed

Noticed "* We are completely uploaded and fine" for downloads also #13093

Karthikdasari0423 opened this issue Mar 9, 2024 · 2 comments
Assignees
@icing

Comments

@Karthikdasari0423
Copy link
Contributor

Karthikdasari0423 commented Mar 9, 2024 •
edited

I did this

I downloaded file from nginx server and noticed "* We are completely uploaded and fine" for downloads also.
AFAIK this message pops up only for uploads.

root@ubuntu:~# curl -v -k -# -o /tmp/BPS.pdf --http3-only https://127.0.0.1:8443/BPS.pdf
*   Trying 127.0.0.1:8443...
* QUIC cipher selection: TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_CCM_SHA256
* Skipped certificate verification
* Connected to 127.0.0.1 (127.0.0.1) port 8443
* using HTTP/3
* [HTTP/3] [0] OPENED stream for https://127.0.0.1:8443/BPS.pdf
* [HTTP/3] [0] [:method: GET]
* [HTTP/3] [0] [:scheme: https]
* [HTTP/3] [0] [:authority: 127.0.0.1:8443]
* [HTTP/3] [0] [:path: /BPS.pdf]
* [HTTP/3] [0] [user-agent: curl/8.7.0-DEV]
* [HTTP/3] [0] [accept: */*]
> GET /BPS.pdf HTTP/3
> Host: 127.0.0.1:8443
> User-Agent: curl/8.7.0-DEV
> Accept: */*
>
* We are completely uploaded and fine
< HTTP/3 200
< server: nginx/1.25.4
< date: Sat, 09 Mar 2024 01:44:35 GMT
< content-type: application/pdf
< content-length: 30182355
< last-modified: Fri, 08 Mar 2024 13:05:10 GMT
< etag: "65eb0d06-1cc8bd3"
< alt-svc: h3=":8443"; ma=86400
< x-protocol: HTTP/3.0
< accept-ranges: bytes
<
{ [522 bytes data]
############################################################################################################################## 100.0%* Connection #0 to host 127.0.0.1 left intact

root@ubuntu:~#

I expected the following

i built curl few days back and it is working as expected in older.

root@ubuntu:~# curl -V
curl 8.7.0-DEV (x86_64-pc-linux-gnu) libcurl/8.7.0-DEV quictls/3.1.4 zlib/1.2.11 brotli/1.0.9 libpsl/0.21.0 nghttp2/1.61.0-DEV ngtcp2/1.2.0 nghttp3/1.1.0 OpenLDAP/2.5.16
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns ldap ldaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli HSTS HTTP2 HTTP3 HTTPS-proxy IPv6 Largefile libz NTLM PSL SSL threadsafe TLS-SRP UnixSockets
root@ubuntu:~#


root@ubuntu:~# curl -v -k -# -o /tmp/BPS.pdf --http3-only --limit-rate 1M https://127.0.0.1:8443/BPS.pdf
*   Trying 127.0.0.1:8443...
* QUIC cipher selection: TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_CCM_SHA256
* Skipped certificate verification
* Connected to 127.0.0.1 (127.0.0.1) port 8443
* using HTTP/3
* [HTTP/3] [0] OPENED stream for https://127.0.0.1:8443/BPS.pdf
* [HTTP/3] [0] [:method: GET]
* [HTTP/3] [0] [:scheme: https]
* [HTTP/3] [0] [:authority: 127.0.0.1:8443]
* [HTTP/3] [0] [:path: /BPS.pdf]
* [HTTP/3] [0] [user-agent: curl/8.7.0-DEV]
* [HTTP/3] [0] [accept: */*]
> GET /BPS.pdf HTTP/3
> Host: 127.0.0.1:8443
> User-Agent: curl/8.7.0-DEV
> Accept: */*
>
< HTTP/3 200
< server: nginx/1.25.4
< date: Sat, 09 Mar 2024 01:41:17 GMT
< content-type: application/pdf
< content-length: 30182355
< last-modified: Sun, 03 Mar 2024 08:47:37 GMT
< etag: "65e43929-1cc8bd3"
< alt-svc: h3=":8443"; ma=86400
< x-protocol: HTTP/3.0
< accept-ranges: bytes
<
{ [32768 bytes data]
################################################################################################################################# 100.0%* Connection #0 to host 127.0.0.1 left intact

root@ubuntu:~#

curl/libcurl version

root@ubuntu:~# curl -V
curl 8.7.0-DEV (x86_64-pc-linux-gnu) libcurl/8.7.0-DEV quictls/3.1.4 zlib/1.2.11 brotli/1.1.0 libpsl/0.21.0 nghttp2/1.61.0-DEV ngtcp2/1.2.0 nghttp3/1.1.0 OpenLDAP/2.5.16
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns ldap ldaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli HSTS HTTP2 HTTP3 HTTPS-proxy IPv6 Largefile libz NTLM PSL SSL threadsafe TLS-SRP UnixSockets
root@ubuntu:~#

operating system

root@ubuntu:~# uname -a
Linux ubuntu 5.15.0-60-generic #66-Ubuntu SMP Fri Jan 20 14:29:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
root@ubuntu:~#
@icing icing self-assigned this Mar 11, 2024
icing added a commit to icing/curl that referenced this issue Mar 11, 2024
@icing
Clarify message when request has been sent off
518c30f 
- refs curl#13093
- Change the "uploaded and fine" message for requests
  without a body
@icing icing mentioned this issue Mar 11, 2024
Closed
@icing
Copy link
Contributor

icing commented Mar 11, 2024

Please see #13095 for a fix of the message printed when the requests have no body, e.g. are not really an "upload".

@Karthikdasari0423
Copy link
Contributor Author

Thanks @icing

@bagder bagder closed this as completed in 6aeb729 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icing icing

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icing @Karthikdasari0423