cmake: fix CURL_WINDOWS_SSPI=ON with Schannel disabled
#13061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change `CURL_WINDOWS_SSPI` was accidentally forced `OFF` when building without the Schannel TLS backend. This in turn may have caused Kerberos, SPNEGO and SSPI features disappearing even with `CURL_WINDOWS_SSPI=ON` set. This patch fixes it by using the `CURL_USE_SCHANNEL` setting as a default for `CURL_WINDOWS_SSPI`, but allowing a manual override. Ref: curl#13056 Closes #xxxxx
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Mar 6, 2024
After disabling MultiSSL (due to HTTP/3 incompatibility) and Schannel with it, Kerberos/SPNEGO/SSPI feature were gone, because they depended on the SSPI build option which got its default from the Schannel-enabler option. A related issue is that the SSPI build option `BUILD_WINDOWS_SSPI` is broken, up until 8.6.0, so we use a workaround until merging the fix upstream and switching to a clean solution for 8.7.0. Depends on curl/curl#13061 for 8.7.0. Reported-by: Andreas Loew Fixes curl/curl#13056
vszakats
changed the title
CURL_WINDOWS_SSPI=ON option with Schannel disabledCURL_WINDOWS_SSPI=ON with Schannel disabled
bagder
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change
CURL_WINDOWS_SSPIwas accidentally forcedOFFwhen building without the Schannel TLS backend.This in turn may have caused Kerberos, SPNEGO and SSPI features
disappearing even with
CURL_WINDOWS_SSPI=ONset.This patch fixes it by using the
CURL_USE_SCHANNELsetting as adefault for
CURL_WINDOWS_SSPI, but allowing a manual override.Also update the option text to better tell its purpose.
Thanks-to: Andreas Loew
Ref: #13056
Closes #13061