Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: better error message for HTTP/1.x response without status line #13045

Closed
wants to merge 1 commit into from

Conversation

mkauf
Copy link
Contributor

@mkauf mkauf commented Mar 4, 2024

If a response without a status line is received, and the connection is known to use HTTP/1.x (not HTTP/0.9), report the error "Invalid status line" instead of "Received HTTP/0.9 when not allowed".

@bagder
Copy link
Member

bagder commented Mar 4, 2024

The first line coming from a HTTP/1.0 or HTTP/1.1 server is called the Status Line. The headers start after that initial line.

If a response without a status line is received, and the connection is
known to use HTTP/1.x (not HTTP/0.9), report the error "Invalid status
line" instead of "Received HTTP/0.9 when not allowed".
@mkauf mkauf changed the title http: better error message for weird HTTP/1.x response without headers http: better error message for HTTP/1.x response without status line Mar 5, 2024
@mkauf
Copy link
Contributor Author

mkauf commented Mar 5, 2024

@bagder : Thanks, I have updated this pull request.

@bagder
Copy link
Member

bagder commented Mar 5, 2024

Thanks!

@bagder bagder closed this in df1fcb4 Mar 5, 2024
@mkauf mkauf deleted the http_weird_statusline branch March 5, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants