Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torture test failure in test 56 #13020

Closed
dfandrich opened this issue Mar 1, 2024 · 1 comment
Closed

Torture test failure in test 56 #13020

dfandrich opened this issue Mar 1, 2024 · 1 comment
Assignees
@icing
Labels
tests

Comments

@dfandrich
Copy link
Contributor

I did this

make test TEST_Q='-a -p -n -t146 56'

The test failed with:

test 0056...[HTTP POST with *HUGE* request and chunked transfer-encoding]
 166 functions to make fail
 system() returned 34304
 56: torture FAILED: function number 146 in test.
 invoke with "-t146" to repeat this single case.

When run under gdb, the message:

lt-curl: /home/dan/src/curl-git/lib/request.c:240: req_send_buffer_add: Assertion (size_t)n == blen' failed.`

appears. The failure can also be seen in this log. This line was last changed in commit 9369c30 PR #12969 @icing

I expected the following

The test should pass the torture tests.

curl/libcurl version

curl 8.7.0-DEV commit 89733e2

operating system

Linux x86_64 glibc
@icing icing self-assigned this Mar 1, 2024
icing added a commit to icing/curl that referenced this issue Mar 1, 2024
@icing
bufq, writing into a softlimit queue cannot be partial
8581705 
- refs curl#13020
- when unable to obtain a new chunk on a softlimit bufq,
  this is an allocation error and needs to be reported as
  such.
- writes into a soflimit bufq never must be partial success
@icing icing mentioned this issue Mar 1, 2024
Closed
@icing
Copy link
Contributor

icing commented Mar 1, 2024

Nice find! Please see #13023 for the fix.

@bagder bagder added the tests label Mar 3, 2024
@bagder bagder closed this as completed in b1005d1 Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icing icing

Labels
tests
Milestone
No milestone
Development

No branches or pull requests
3 participants
@icing @bagder @dfandrich