fopen: fix narrowing conversion warning on 32-bit Android #12998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The description says "on 32-bit Android" but the code is clearly done unconditionally for all Android builds. I presume that is what is intended even though there is no mention of non-32 bit? |
|
Ah, yes. Sorry. For 64-bit |
kiefer-andreas
force-pushed
the
fopen_android_warning_regression
branch
from
0989516
to
5c3ae04
Compare
This was fixed in commit 06dc599, but came back in commit 03cb1ff. When building for 32-bit ARM or x86 Android, `st_mode` is defined as `unsigned int` instead of `mode_t`, resulting in a `-Wimplicit-int-conversion` clang warning because `mode_t` is `unsigned short`. Add a cast to silence the warning, but only for Android builds, because other architectures and platforms are not affected. Ref: https://android.googlesource.com/platform/bionic/+/refs/tags/ndk-r25c/libc/include/sys/stat.h#86
kiefer-andreas
force-pushed
the
fopen_android_warning_regression
branch
from
5c3ae04
to
d9fcbc2
Compare
bagder
approved these changes
Feb 27, 2024
MarcelRaad
approved these changes
Feb 27, 2024
|
Thanks Andreas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed in commit 06dc599, but came back in commit 03cb1ff.
When building for 32-bit ARM or x86 Android,
st_modeis defined asunsigned intinstead ofmode_t, resulting in a-Wimplicit-int-conversionclang warning becausemode_tisunsigned short. Add a cast to silence the warning, but only for Android builds, because other architectures and platforms are not affected.Ref: https://android.googlesource.com/platform/bionic/+/refs/tags/ndk-r25c/libc/include/sys/stat.h#86