Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure with cmake 3.19.2 #12920

Closed
dfandrich opened this issue Feb 9, 2024 · 10 comments
Closed

Build failure with cmake 3.19.2 #12920

dfandrich opened this issue Feb 9, 2024 · 10 comments
Labels
build cmake documentation

Comments

@dfandrich
Copy link
Contributor

dfandrich commented Feb 9, 2024 •
edited by vszakats

I did this

Trying to configure 8.6.0 (or master) using cmake 3.19.2 results in the error:

-- Enabled SSL backends: OpenSSL
-- Configuring done
CMake Error:
  Error evaluating generator expression:

    $<LIST:TRANSFORM,curl_easy_cleanup.3;curl_easy_duphandle.3;curl_easy_escape.3;curl_easy_getinfo.3;curl_easy_header.3;curl_easy_init.3;curl_easy_nextheader.3;curl_easy_option_by_id.3;curl_easy_option_by_name.3;curl_easy_option_next.3;curl_easy_pause.3;curl_easy_perform.3;curl_easy_recv.3;curl_easy_reset.3;curl_easy_send.3;curl_easy_setopt.3;curl_easy_strerror.3;curl_easy_unescape.3;curl_easy_upkeep.3;curl_escape.3;curl_formadd.3;curl_formfree.3;curl_formget.3;curl_free.3;curl_getdate.3;curl_getenv.3;curl_global_cleanup.3;curl_global_init.3;curl_global_init_mem.3;curl_global_trace.3;curl_global_sslset.3;curl_mime_addpart.3;curl_mime_data.3;curl_mime_data_cb.3;curl_mime_encoder.3;curl_mime_filedata.3;curl_mime_filename.3;curl_mime_free.3;curl_mime_headers.3;curl_mime_init.3;curl_mime_name.3;curl_mime_subparts.3;curl_mime_type.3;curl_mprintf.3;curl_multi_add_handle.3;curl_multi_assign.3;curl_multi_cleanup.3;curl_multi_fdset.3;curl_multi_get_handles.3;curl_multi_info_read.3;curl_multi_init.3;curl_multi_perform.3;curl_multi_poll.3;curl_multi_remove_handle.3;curl_multi_setopt.3;curl_multi_socket.3;curl_multi_socket_action.3;curl_multi_socket_all.3;curl_multi_strerror.3;curl_multi_timeout.3;curl_multi_wakeup.3;curl_multi_wait.3;curl_pushheader_bynum.3;curl_pushheader_byname.3;curl_share_cleanup.3;curl_share_init.3;curl_share_setopt.3;curl_share_strerror.3;curl_slist_append.3;curl_slist_free_all.3;curl_strequal.3;curl_strnequal.3;curl_unescape.3;curl_url.3;curl_url_cleanup.3;curl_url_dup.3;curl_url_get.3;curl_url_set.3;curl_url_strerror.3;curl_version.3;curl_version_info.3;curl_ws_meta.3;curl_ws_recv.3;curl_ws_send.3;libcurl-easy.3;libcurl-env.3;libcurl-env-dbg.3;libcurl-errors.3;libcurl-multi.3;libcurl-security.3;libcurl-share.3;libcurl-symbols.3;libcurl-thread.3;libcurl-tutorial.3;libcurl-url.3;libcurl-ws.3;libcurl.3,PREPEND,/home/dan/src/curl-git/build/docs/libcurl/>

  Expression did not evaluate to a known generator expression

Bisecting shows commit a808aab is at fault. This version of cmake is only a couple of years old and the documentation says cmake 3.7 is the earliest supported version, so I would expect this to work.

I expected the following

cmake should run without error.

curl/libcurl version

curl 8.6.0

operating system

Linux x86_64
@vszakats
Copy link
Member

vszakats commented Feb 9, 2024 •
edited

@dfandrich: This syntax was in fact introduced a few commits earlier in ea0b575 (not by me).

It's a new here that someone must be pointed out by name to be "at fault"!

@dfandrich
Copy link
Contributor Author

Commit 1621136 (the previous one) configures fine but commit a808aab is the one that starts showing this problem (at least without specifying any build options on my system).

@vszakats
Copy link
Member

These still have nothing to do with the introduction of the breaking CMake syntax.

It's trivial to look up when it was introduced:

$ git log -S 'LIST:TRANSFORM'
commit ea0b575dab86a3c44dd1d547dc500276266aa382
[...]

@vszakats
Copy link
Member

vszakats commented Feb 10, 2024 •
edited

The reason you are not seeing the problem earlier, is because my "at fault" (your wording) commit made the libcurl manual option to work by default (that is without having to manually enable building the curl manual too with another option). But, given the necessary options, you'd see the same issue after the initial commit.

@dfandrich
Copy link
Contributor Author

Makes, sense and what I was hedging about with "without specifying any build options". @levitte, is there an alternate way of doing this that works on older cmake?

@bagder
Copy link
Member

bagder commented Feb 10, 2024

Can we do something in the builds/CI to detect when we rely on too new cmake features?

@levitte levitte mentioned this issue Feb 10, 2024
Closed
levitte added a commit to levitte/curl that referenced this issue Feb 10, 2024
@levitte
[CMake]: Fix docs/libcurl/CMakeLists.txt for older CMake versions
ea07abf 
A generator expression was added, that was a bit too modern.
Forunately, a foreach() loop can produce the same result relatively
easily.

Fixes curl#12920
@levitte
Copy link
Contributor

levitte commented Feb 10, 2024

It was quite easy to replace the generator expression with a loop. Isn't quite as nice, but should be workable much further back in CMake versions.

This has me wonder if I should have a container in place with an old CMake, just to test this sort of thing (no, not just for curl...)

Anyway, fix in #12922

@levitte
Copy link
Contributor

levitte commented Feb 10, 2024

Can we do something in the builds/CI to detect when we rely on too new cmake features?

It's probably possible to install a cmake package with an appropriately old version.

Question is, how far back do the package repositories go? That being said, this can also be solved, by having a package repository of your own with suitably old stuff and try to install from that [yeah, cringe, and unsure if that's actually possible], or self-host a runner (for those CIs that permit it), again with suitably old stuff [yeah, cringe].

@dfandrich
Copy link
Contributor Author

dfandrich commented Feb 10, 2024 via email

levitte added a commit to levitte/curl that referenced this issue Feb 10, 2024
@levitte
[CMake]: Fix docs/libcurl/CMakeLists.txt for older CMake versions
2742191 
A generator expression was added, that was a bit too modern.
Forunately, a foreach() loop can produce the same result relatively
easily.

Fixes curl#12920
levitte added a commit to levitte/curl that referenced this issue Feb 10, 2024
@levitte
[CMake]: Fix docs/.../CMakeLists.txt for older CMake versions
b340b2e 
A generator expression was added in some CMakeLists.txts, that was a bit
too modern.  Forunately, a foreach() loop can produce the same result
relatively easily.

Fixes curl#12920
levitte added a commit to levitte/curl that referenced this issue Feb 11, 2024
@levitte
[CMake]: Fix docs/.../CMakeLists.txt for older CMake versions
4c0a4cb 
A generator expression was added in some CMakeLists.txts, that was a bit
too modern.  Forunately, a foreach() loop can produce the same result
relatively easily.

Fixes curl#12920
96fps referenced this issue in SerenityOS/serenity Feb 12, 2024
@kennethmyhra @timschumi
Ports: Update curl to 8.6.0
e865b3e
@jay jay closed this as completed in b2497a8 Feb 18, 2024
gmta added a commit to gmta/serenity that referenced this issue Feb 21, 2024
@gmta
Ports: Patch curl CMake issue
5d310d7 
The CMake syntax was a bit too new for our toolchain's CMake. The
following patch was backported:

  curl/curl@b2497a8

Relevant issue:

  curl/curl#12920

As soon as the fix lands in the next curl version, we can remove this
patch again. :^)
@gmta gmta mentioned this issue Feb 21, 2024
Merged
gmta added a commit to SerenityOS/serenity that referenced this issue Feb 21, 2024
@gmta
Ports: Patch curl CMake issue
e54e2a5 
The CMake syntax was a bit too new for our toolchain's CMake. The
following patch was backported:

  curl/curl@b2497a8

Relevant issue:

  curl/curl#12920

As soon as the fix lands in the next curl version, we can remove this
patch again. :^)
@thomgree
Copy link

I worked around this using the BUILD_LIBCURL_DOCS=OFF CMake option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build cmake documentation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: fix syntax for older CMake versions levitte/curl
5 participants
@bagder @dfandrich @levitte @vszakats @thomgree